[GitHub] ravipesala commented on a change in pull request #3121: [CARBONDATA-3287]Remove the validation for same schema in a location and fix drop datamap issue

[GitBox]

ravipesala commented on a change in pull request #3121: [CARBONDATA-3287]Remove the validation for same schema in a location and fix drop datamap issue
URL: https://github.com/apache/carbondata/pull/3121#discussion_r254148734
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java
 ##########
 @@ -184,7 +188,9 @@ private static CarbonMeasure getCarbonMetadataMeasure(String name, List<CarbonMe
   }
 
   private static void setDimAndMsrColumnNode(FilterProcessVO processVO, ColumnExpression col,
-      boolean[] isFilterDimensions, boolean[] isFilterMeasures) {
+      boolean[] isFilterDimensions, boolean[] isFilterMeasures, CarbonTable table) {
+    boolean isDimensionFromExpression = col.isDimension();
+    boolean isMeasureFromExpression = col.isMeasure();
 
 Review comment:
   How `ColumnExpression` knows about whether it is dimension or measure?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services