[GitHub] shardul-cr7 commented on a change in pull request #3112: [CARBONDATA-3280] Fix the issue of SDK assert can't work

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] shardul-cr7 commented on a change in pull request #3112: [CARBONDATA-3280] Fix the issue of SDK assert can't work

GitBox
shardul-cr7 commented on a change in pull request #3112: [CARBONDATA-3280] Fix the issue of SDK assert can't work
URL: https://github.com/apache/carbondata/pull/3112#discussion_r251705006
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java
 ##########
 @@ -127,6 +127,29 @@ public void testWriteAndReadFiles() throws IOException, InterruptedException {
     FileUtils.deleteDirectory(new File(path));
   }
 
+
+  @Test
+  public void testReadBatchWithZeroBatchSize() throws Exception {
 
 Review comment:
   @xubo245 this test case is almost same to testReadWithZeroBatchSize()..why is there need for this testcase?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services