[GitHub] shardul-cr7 opened a new pull request #3104: [HOTFIX] Fix select query on varchar column with large data fails with jvm crash

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] shardul-cr7 opened a new pull request #3104: [HOTFIX] Fix select query on varchar column with large data fails with jvm crash

GitBox
shardul-cr7 opened a new pull request #3104: [HOTFIX] Fix select query on varchar column with large data fails with jvm crash
URL: https://github.com/apache/carbondata/pull/3104
 
 
   **Problem** : When select query fired on varchar column having large data it results in JVM crash because when when we increase the ReusableBuffer by 30% the new size gets gets reduced because requestSize * 30 gets out of range for int which gives a negative value and the total size gets reduced.
   
   **Solution** : While assigning the size to ByteBuffer we first check if total size less than the requested size then we pass requested to to the ByteBuffer.
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
   
    - [ ] Any backward compatibility impacted?
   
    - [ ] Document update required?
   
    - [ ] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services