[GitHub] sujith71955 commented on a change in pull request #3134: [CARBONDATA-3302] [Spark-Integration] code cleaning related to CarbonCreateTable command

[GitBox]

sujith71955 commented on a change in pull request #3134: [CARBONDATA-3302] [Spark-Integration] code cleaning related to CarbonCreateTable command
URL: https://github.com/apache/carbondata/pull/3134#discussion_r259674899
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
 ##########
 @@ -78,8 +78,8 @@ case class CarbonCreateTableCommand(
         path
       }
       val streaming = tableInfo.getFactTable.getTableProperties.get("streaming")
-      if (path.startsWith("s3") && streaming != null && streaming != null &&
-          streaming.equalsIgnoreCase("true")) {
+      if (streaming != null &&
+        streaming.equalsIgnoreCase("true") && path.startsWith("s3")) {
 
 Review comment:
   Statement "tableInfo.getFactTable.getTableProperties.get("streaming")" can return null if there is no property called streaming, so i think we shall have this check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services