[GitHub] xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties

[GitBox]

xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties
URL: https://github.com/apache/carbondata/pull/3063#discussion_r247352408
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
 ##########
 @@ -787,6 +787,19 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
       }
     }
 
+    // range_column should be there in create table cols
+    if (tableProperties.get(CarbonCommonConstants.RANGE_COLUMN).isDefined) {
+      val rangeColumn = tableProperties.get(CarbonCommonConstants.RANGE_COLUMN).get.trim
 
 Review comment:
   I think we can also check the number of fields and complain that carbondata only support specifying one fields now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services