[GitHub] xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties

[GitBox]

xuchuanyin commented on a change in pull request #3063: [CARBONDATA-3242] Move Range_Column into the table level properties
URL: https://github.com/apache/carbondata/pull/3063#discussion_r247352223
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestRangeColumnDataLoad.scala
 ##########
 @@ -99,19 +114,53 @@ class TestRangeColumnDataLoad extends QueryTest with BeforeAndAfterEach with Bef
       """
         | CREATE TABLE carbon_range_column4(id INT, name STRING, city STRING, age INT)
         | STORED BY 'org.apache.carbondata.format'
-        | TBLPROPERTIES('SORT_SCOPE'='GLOBAL_SORT', 'SORT_COLUMNS'='name, city')
+        | TBLPROPERTIES('SORT_SCOPE'='LOCAL_SORT', 'SORT_COLUMNS'='name, city', 'range_column'='name')
       """.stripMargin)
 
     val dataSkewPath = s"$resourcesPath/range_column"
 
     sql(s"LOAD DATA LOCAL INPATH '$dataSkewPath' INTO TABLE carbon_range_column4 " +
-        "OPTIONS('GLOBAL_SORT_PARTITIONS'='5', 'range_column'='name', " +
-        "'BAD_RECORDS_ACTION'='force')")
+        "OPTIONS('GLOBAL_SORT_PARTITIONS'='5', 'BAD_RECORDS_ACTION'='force')")
 
     assert(getIndexFileCount("carbon_range_column4") === 5)
     checkAnswer(sql("SELECT COUNT(*) FROM carbon_range_column4"), Seq(Row(10)))
   }
 
+  test("range_column with system property carbon.range.column.scale.factor") {
+    CarbonProperties.getInstance().addProperty(
+      CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR,
+      "10"
+    )
+
+    sql(
+      """
+        | CREATE TABLE carbon_range_column5(id INT, name STRING, city STRING, age INT)
+        | STORED BY 'org.apache.carbondata.format'
+        | TBLPROPERTIES('SORT_SCOPE'='LOCAL_SORT', 'SORT_COLUMNS'='name, city', 'range_column'='name')
+      """.stripMargin)
+
+    sql(s"LOAD DATA LOCAL INPATH '$filePath' INTO TABLE carbon_range_column5 ")
+
+    assert(getIndexFileCount("carbon_range_column5") === 1)
+    checkAnswer(sql("SELECT COUNT(*) FROM carbon_range_column5"), Seq(Row(12)))
+    checkAnswer(sql("SELECT * FROM carbon_range_column5"),
+      sql("SELECT * FROM carbon_range_column5 ORDER BY name"))
+  }
+
+  test("set and unset table property: range_column") {
+    sql(
+      """
+        | CREATE TABLE carbon_range_column6(id INT, name STRING, city STRING, age INT)
+        | STORED BY 'org.apache.carbondata.format'
+        | TBLPROPERTIES('SORT_SCOPE'='LOCAL_SORT', 'SORT_COLUMNS'='name, city')
+      """.stripMargin)
+
+    sql("ALTER TABLE carbon_range_column6 SET TBLPROPERTIES('range_column'='city')")
+    sql("ALTER TABLE carbon_range_column6 SET TBLPROPERTIES('range_column'='name')")
+    sql("ALTER TABLE carbon_range_column6 UNSET TBLPROPERTIES('range_column')")
+    sql("ALTER TABLE carbon_range_column6 SET TBLPROPERTIES('range_column'='name')")
+  }
+
 
 Review comment:
   Do we support using this property in dafaframe?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services