[GitHub] xuchuanyin commented on a change in pull request #3079: [WIP][CARBONDATA-3255] Support binary data type

[GitBox]

xuchuanyin commented on a change in pull request #3079: [WIP][CARBONDATA-3255] Support binary data type
URL: https://github.com/apache/carbondata/pull/3079#discussion_r251234055
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/FieldEncoderFactory.java
 ##########
 @@ -130,6 +130,9 @@ public FieldConverter createFieldEncoder(DataField dataField,
         return new NonDictionaryFieldConverterImpl(dataField, nullFormat, index, isEmptyBadRecord);
       }
     } else {
+      if (dataField.getColumn().getDataType() == DataTypes.BINARY) {
 
 Review comment:
   So binary is a subtype of measure?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services