[GitHub] xuchuanyin commented on a change in pull request #3102: [CARBONDATA-3272]fix ArrayIndexOutOfBoundsException of horizontal compaction during update, when cardinality changes within a segment

[GitBox]

xuchuanyin commented on a change in pull request #3102: [CARBONDATA-3272]fix ArrayIndexOutOfBoundsException of horizontal compaction during update, when cardinality changes within a segment
URL: https://github.com/apache/carbondata/pull/3102#discussion_r251231101
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
 ##########
 @@ -147,6 +147,7 @@ private static void groupCorrespodingInfoBasedOnTask(TableBlockInfo info,
         blockInfo.setDataFileFooter(dataFileMatadata);
       } else {
         dataFileMatadata = CarbonUtil.readMetadataFile(blockInfo);
+        blockInfo.setDataFileFooter(dataFileMatadata);
 
 Review comment:
   consider to move this sentence （Line147/150） out of the branches cause all the branches have them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services