[GitHub] xuchuanyin commented on a change in pull request #3108: [CARBONDATA-3277] Support to show subquery for datamap

[GitBox]

xuchuanyin commented on a change in pull request #3108: [CARBONDATA-3277] Support to show subquery for datamap
URL: https://github.com/apache/carbondata/pull/3108#discussion_r253248782
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDataMapShowCommand.scala
 ##########
 @@ -43,7 +44,8 @@ case class CarbonDataMapShowCommand(tableIdentifier: Option[TableIdentifier])
     Seq(AttributeReference("DataMapName", StringType, nullable = false)(),
       AttributeReference("ClassName", StringType, nullable = false)(),
       AttributeReference("Associated Table", StringType, nullable = false)(),
-      AttributeReference("DataMap Properties", StringType, nullable = false)())
+      AttributeReference("DataMap Properties", StringType, nullable = false)(),
+      AttributeReference("Subquery", StringType, nullable = false)())
 
 Review comment:
   How about setting this field nullable so that in case of other type of datamap we can just return null instead of empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services