[GitHub] xuchuanyin commented on a change in pull request #3113: [CARBONDATA-3284] [CARBONDATA-3285] Workaround for Create-PreAgg Datamap Fail & Sort-Columns Fix

[GitBox]

xuchuanyin commented on a change in pull request #3113: [CARBONDATA-3284] [CARBONDATA-3285] Workaround for Create-PreAgg Datamap Fail & Sort-Columns Fix
URL: https://github.com/apache/carbondata/pull/3113#discussion_r253247971
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
 ##########
 @@ -3338,4 +3338,20 @@ public static boolean hasEncoding(List<org.apache.carbondata.format.Encoding> en
   public static String generateUUID() {
     return UUID.randomUUID().toString();
   }
+
+  /**
+   * Below method will be used to get the datamap schema name from datamap table name
+   * it will split name based on _ and get the last name
+   * This is only for pre aggregate and timeseries tables
+   *
+   * @param tableName
 
 Review comment:
   please make sure that the comments all are useful and remove the useless ones

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services