Apache CarbonData Dev Mailing List archive

Please vote and advise on building thrift files

Classic

List

Threaded

21 messages Options

Liang Chen

Please vote and advise on building thrift files

Administrator

This post was updated on .

Hi all

Please vote the below proposals or advise other better proposal on building
thrift files.
---------------------------------------------------------------------------------------
CarbonData is file format and introduce Apache thrift for supporting
multiple languages and any language can read the file format written by
thrift.

Following are 2 proposals to build thrift file

*Proposal 1:* provide dependency in maven pom file.

For people(IPMC,PPMC, and others)who want to verify release need to install
thrift for building with this command "mvn clean -Pbuild-with-format
install".

For general users: no need to install thrift and build with command "mvn
clean install", because the dependency provided in maven pom file(already
uploaded the compiled format jar to snapshot repository for dev, and to
release repository once released)

pros: use jar dependency, easy to manage.
cons: verify release need to install thrift.

*Proposal 2: *generate thrift java code and add to system for building
without thrift installation
For people(IPMC,PPMC,and others) who want to verify release,no need to
install thrift and build with command "mvn clean install".

pros: no thrift installation for verify release
cons: introduce around 10k java code to system, for every language(like
C++),need introduce more code.

Regards
Liang

sraghunandan

Re: Please vote and advise on building thrift files

I vote for pooposal 1
On Thu, 17 Nov 2016 at 12:04 AM, Liang Chen <[hidden email]> wrote:

> Hi all
>
> Please vote the below proposals or advise other better proposal on building
> thrift files.
>
>
>
> ---------------------------------------------------------------------------------------
>
> CarbonData is file format and introduce Apache thrift for supporting
> multiple languages and any language can read the file format written by
> thrift.
>
>
>
> Following are 2 proposals to build thrift file
>
>
>
> *Proposal 1:* provide dependency in maven pom file.
>
> For people(IPMC,PPMC, and others)who want to verify release need to install
> thrift for building with this command "mvn clean -Pbuild-with-format
> install".
>
> For general users: no need to install thrift and build with command "mvn
> clean install", because the dependency provided in maven pom file(already
> uploaded the compiled format jar to snapshot repository for dev, and to
> release repository once released)
>
>
>
> pros: use jar dependency, easy to manage.
>
> cons: only verify release need to install thrift.
>
>
>
> *Proposal 2: *generate thrift java code and add to system for building
> without thrift installation
>
>
>
> For people(IPMC,PPMC,and others) who want to verify release,no need to
> install thrift and build with command "mvn clean install".
>
>
> pros: no thrift installation for verify release
>
> cons: introduce around 10k java code to system, for every language(like
> C++),need introduce more code.
>
>
> Regards
> Liang
>

杰

回复： Please vote and advise on building thrift files

+1 for proposal 1

Regards
Jay

------------------ 原始邮件 ------------------
发件人: "Raghunandan S";<[hidden email]>;
发送时间: 2016年11月17日(星期四) 上午9:12
收件人: "dev"<[hidden email]>;

主题: Re: Please vote and advise on building thrift files

I vote for pooposal 1
On Thu, 17 Nov 2016 at 12:04 AM, Liang Chen <[hidden email]> wrote:

chxmlmn

Re: Please vote and advise on building thrift files

In reply to this post by Liang Chen

I vote for pooposal 1

张家锋

Re: Please vote and advise on building thrift files

In reply to this post by Liang Chen

+1 for proposal 1

ZhuWilliam

Re: Please vote and advise on building thrift files

+1 for proposal 1 .

Auto generated code should not be added to project. Also most the of time ,people who dive into carbondata may not touch format code.

hexiaoqiao

Re: Please vote and advise on building thrift files

+1 for proposal 1.

On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]> wrote:

> +1 for proposal 1 .
>
> Auto generated code should not be added to project. Also most the of time
> ,people who dive into carbondata may not touch format code.
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
> advise-on-building-thrift-files-tp2952p2957.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>

ravipesala

Re: Please vote and advise on building thrift files

+1 for proposal 1

On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:

> +1 for proposal 1.
>
> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
> wrote:
>
> > +1 for proposal 1 .
> >
> > Auto generated code should not be added to project. Also most the of time
> > ,people who dive into carbondata may not touch format code.
> >
> >
> >
> > --
> > View this message in context: http://apache-carbondata-
> > mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
> > advise-on-building-thrift-files-tp2952p2957.html
> > Sent from the Apache CarbonData Mailing List archive mailing list archive
> > at Nabble.com.
> >
>

--
Thanks & Regards,
Ravi

邢冰

Re: Re: Please vote and advise on building thrift files

+1 for proposal 1

thx

发自网易邮箱大师
On 11/17/2016 12:09, Ravindra Pesala wrote:
+1 for proposal 1

On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:

--
Thanks & Regards,
Ravi

金铸

Re: Please vote and advise on building thrift files

+1 for proposal 1

在 2016/11/17 12:13, 邢冰写道:

> +1 for proposal 1
>
> thx
>
>
>
>
> 发自网易邮箱大师
> On 11/17/2016 12:09, Ravindra Pesala wrote:
> +1 for proposal 1
>
> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
>
>> +1 for proposal 1.
>>
>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
>> wrote:
>>
>>> +1 for proposal 1 .
>>>
>>> Auto generated code should not be added to project. Also most the of time
>>> ,people who dive into carbondata may not touch format code.
>>>
>>>
>>>
>>> --
>>> View this message in context: http://apache-carbondata-
>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
>>> advise-on-building-thrift-files-tp2952p2957.html
>>> Sent from the Apache CarbonData Mailing List archive mailing list archive
>>> at Nabble.com.
>>>
>
>
> --
> Thanks & Regards,
> Ravi

---------------------------------------------------------------------------------------------------
Confidentiality Notice: The information contained in this e-mail and any accompanying attachment(s)
is intended only for the use of the intended recipient and may be confidential and/or privileged of
Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader of this communication is
not the intended recipient, unauthorized use, forwarding, printing, storing, disclosure or copying
is strictly prohibited, and may be unlawful.If you have received this communication in error,please
immediately notify the sender by return e-mail, and delete the original message and all copies from
your system. Thank you.
---------------------------------------------------------------------------------------------------

kumarvishal09

Re: Please vote and advise on building thrift files

+1 for proposal 1

-Regards
Kumar Vishal

On Nov 17, 2016 09:58, "金铸" <[hidden email]> wrote:

> +1 for proposal 1
>
>
> 在 2016/11/17 12:13, 邢冰写道:
>
>> +1 for proposal 1
>>
>> thx
>>
>>
>>
>>
>> 发自网易邮箱大师
>> On 11/17/2016 12:09, Ravindra Pesala wrote:
>> +1 for proposal 1
>>
>> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
>>
>> +1 for proposal 1.
>>>
>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
>>> wrote:
>>>
>>> +1 for proposal 1 .
>>>>
>>>> Auto generated code should not be added to project. Also most the of
>>>> time
>>>> ,people who dive into carbondata may not touch format code.
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context: http://apache-carbondata-
>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
>>>> advise-on-building-thrift-files-tp2952p2957.html
>>>> Sent from the Apache CarbonData Mailing List archive mailing list
>>>> archive
>>>> at Nabble.com.
>>>>
>>>>
>>
>> --
>> Thanks & Regards,
>> Ravi
>>
>
>
>
>
> ------------------------------------------------------------
> ---------------------------------------
> Confidentiality Notice: The information contained in this e-mail and any
> accompanying attachment(s)
> is intended only for the use of the intended recipient and may be
> confidential and/or privileged of
> Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader
> of this communication is
> not the intended recipient, unauthorized use, forwarding, printing,
> storing, disclosure or copying
> is strictly prohibited, and may be unlawful.If you have received this
> communication in error,please
> immediately notify the sender by return e-mail, and delete the original
> message and all copies from
> your system. Thank you.
> ------------------------------------------------------------
> ---------------------------------------
>

kumar vishal

anuragknoldus

Re: Please vote and advise on building thrift files

+1 for proposal 1

On Thu, Nov 17, 2016 at 3:56 PM, Kumar Vishal <[hidden email]>
wrote:

> +1 for proposal 1
>
> -Regards
> Kumar Vishal
>
> On Nov 17, 2016 09:58, "金铸" <[hidden email]> wrote:
>
> > +1 for proposal 1
> >
> >
> > 在 2016/11/17 12:13, 邢冰写道:
> >
> >> +1 for proposal 1
> >>
> >> thx
> >>
> >>
> >>
> >>
> >> 发自网易邮箱大师
> >> On 11/17/2016 12:09, Ravindra Pesala wrote:
> >> +1 for proposal 1
> >>
> >> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
> >>
> >> +1 for proposal 1.
> >>>
> >>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
> >>> wrote:
> >>>
> >>> +1 for proposal 1 .
> >>>>
> >>>> Auto generated code should not be added to project. Also most the of
> >>>> time
> >>>> ,people who dive into carbondata may not touch format code.
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> View this message in context: http://apache-carbondata-
> >>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
> >>>> advise-on-building-thrift-files-tp2952p2957.html
> >>>> Sent from the Apache CarbonData Mailing List archive mailing list
> >>>> archive
> >>>> at Nabble.com.
> >>>>
> >>>>
> >>
> >> --
> >> Thanks & Regards,
> >> Ravi
> >>
> >
> >
> >
> >
> > ------------------------------------------------------------
> > ---------------------------------------
> > Confidentiality Notice: The information contained in this e-mail and any
> > accompanying attachment(s)
> > is intended only for the use of the intended recipient and may be
> > confidential and/or privileged of
> > Neusoft Corporation, its subsidiaries and/or its affiliates. If any
> reader
> > of this communication is
> > not the intended recipient, unauthorized use, forwarding, printing,
> > storing, disclosure or copying
> > is strictly prohibited, and may be unlawful.If you have received this
> > communication in error,please
> > immediately notify the sender by return e-mail, and delete the original
> > message and all copies from
> > your system. Thank you.
> > ------------------------------------------------------------
> > ---------------------------------------
> >
>

--
*Thanks&regards*

*Anurag Srivastava**Software Consultant*
*Knoldus Software LLP*

*India - US - Canada*
* Twitter <http://www.twitter.com/anuragknoldus> | FB
<http://www.facebook.com/anuragsrivastava.06> | LinkedIn
<https://in.linkedin.com/pub/anurag-srivastava/5a/b6/441>*

Jihong Ma

RE: Please vote and advise on building thrift files

+1 for proposal 1.

Jihong

-----Original Message-----
From: Anurag Srivastava [mailto:[hidden email]]
Sent: Thursday, November 17, 2016 2:32 AM
To: [hidden email]
Subject: Re: Please vote and advise on building thrift files

+1 for proposal 1

On Thu, Nov 17, 2016 at 3:56 PM, Kumar Vishal <[hidden email]>
wrote:

Aniket Adnaik

Re: Please vote and advise on building thrift files

In reply to this post by Liang Chen

+1 for Proposal 1

Best Regards,
Aniket

On Wed, Nov 16, 2016 at 10:34 AM, Liang Chen <[hidden email]>
wrote:

> Hi all
>
> Please vote the below proposals or advise other better proposal on building
> thrift files.
>
>
> ------------------------------------------------------------
> ---------------------------
>
> CarbonData is file format and introduce Apache thrift for supporting
> multiple languages and any language can read the file format written by
> thrift.
>
>
>
> Following are 2 proposals to build thrift file
>
>
>
> *Proposal 1:* provide dependency in maven pom file.
>
> For people(IPMC,PPMC, and others)who want to verify release need to install
> thrift for building with this command "mvn clean -Pbuild-with-format
> install".
>
> For general users: no need to install thrift and build with command "mvn
> clean install", because the dependency provided in maven pom file(already
> uploaded the compiled format jar to snapshot repository for dev, and to
> release repository once released)
>
>
>
> pros: use jar dependency, easy to manage.
>
> cons: only verify release need to install thrift.
>
>
>
> *Proposal 2: *generate thrift java code and add to system for building
> without thrift installation
>
>
>
> For people(IPMC,PPMC,and others) who want to verify release,no need to
> install thrift and build with command "mvn clean install".
>
>
> pros: no thrift installation for verify release
>
> cons: introduce around 10k java code to system, for every language(like
> C++),need introduce more code.
>
>
> Regards
> Liang
>

hseagle

Re: Please vote and advise on building thrift files

In reply to this post by Liang Chen

+ vote for proposal 1

Jean-Baptiste Onofré

Re: Please vote and advise on building thrift files

+1 for first proposal too.

Regards
JB

⁣

On Nov 18, 2016, 04:05, at 04:05, hseagle <[hidden email]> wrote:
>+ vote for proposal 1
>
>
>
>--
>View this message in context:
>http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2989.html
>Sent from the Apache CarbonData Mailing List archive mailing list
>archive at Nabble.com.

cenyuhai

回复： Please vote and advise on building thrift files

+1 for first proposal too.

------------------ 原始邮件 ------------------
发件人: "Jean-Baptiste Onofr ";<[hidden email]>;
发送时间: 2016年11月18日(星期五) 中午11:11
收件人: "dev"<[hidden email]>;

主题: Re: Please vote and advise on building thrift files

+1 for first proposal too.

Regards
JB

⁣

On Nov 18, 2016, 04:05, at 04:05, hseagle <[hidden email]> wrote:
>+ vote for proposal 1
>
>
>
>--
>View this message in context:
>http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2989.html
>Sent from the Apache CarbonData Mailing List archive mailing list
>archive at Nabble.com.

sujith chacko

Re: Please vote and advise on building thrift files

In reply to this post by 金铸

+1 for first approach.

On Nov 17, 2016 9:58 AM, "金铸" <[hidden email]> wrote:

Fu Chen

Re: Please vote and advise on building thrift files

+1 for Proposal 1

> 在 2016年11月18日，上午11:58，sujith chacko <[hidden email]> 写道：
>
> +1 for first approach.
>
> On Nov 17, 2016 9:58 AM, "金铸" <[hidden email]> wrote:
>
>> +1 for proposal 1
>>
>>
>> 在 2016/11/17 12:13, 邢冰写道:
>>
>>> +1 for proposal 1
>>>
>>> thx
>>>
>>>
>>>
>>>
>>> 发自网易邮箱大师
>>> On 11/17/2016 12:09, Ravindra Pesala wrote:
>>> +1 for proposal 1
>>>
>>> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
>>>
>>> +1 for proposal 1.
>>>>
>>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
>>>> wrote:
>>>>
>>>> +1 for proposal 1 .
>>>>>
>>>>> Auto generated code should not be added to project. Also most the of
>>>>> time
>>>>> ,people who dive into carbondata may not touch format code.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> View this message in context: http://apache-carbondata-
>>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
>>>>> advise-on-building-thrift-files-tp2952p2957.html
>>>>> Sent from the Apache CarbonData Mailing List archive mailing list
>>>>> archive
>>>>> at Nabble.com.
>>>>>
>>>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Ravi
>>>
>>
>>
>>
>>
>> ------------------------------------------------------------
>> ---------------------------------------
>> Confidentiality Notice: The information contained in this e-mail and any
>> accompanying attachment(s)
>> is intended only for the use of the intended recipient and may be
>> confidential and/or privileged of
>> Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader
>> of this communication is
>> not the intended recipient, unauthorized use, forwarding, printing,
>> storing, disclosure or copying
>> is strictly prohibited, and may be unlawful.If you have received this
>> communication in error,please
>> immediately notify the sender by return e-mail, and delete the original
>> message and all copies from
>> your system. Thank you.
>> ------------------------------------------------------------
>> ---------------------------------------
>>

Venkata Gollamudi

Re: Please vote and advise on building thrift files

+1 for solution 1.

Solution 2 would be good if generated code is very less. But Carbondata
thrift generated code is around 10k, which is more. Also later has to
support C++ interface also.

On Sun, Nov 20, 2016, 10:53 PM Fu Chen <[hidden email]> wrote:

> +1 for Proposal 1
> > 在 2016年11月18日，上午11:58，sujith chacko <[hidden email]> 写道：
> >
> > +1 for first approach.
> >
> > On Nov 17, 2016 9:58 AM, "金铸" <[hidden email]> wrote:
> >
> >> +1 for proposal 1
> >>
> >>
> >> 在 2016/11/17 12:13, 邢冰写道:
> >>
> >>> +1 for proposal 1
> >>>
> >>> thx
> >>>
> >>>
> >>>
> >>>
> >>> 发自网易邮箱大师
> >>> On 11/17/2016 12:09, Ravindra Pesala wrote:
> >>> +1 for proposal 1
> >>>
> >>> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
> >>>
> >>> +1 for proposal 1.
> >>>>
> >>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
> >>>> wrote:
> >>>>
> >>>> +1 for proposal 1 .
> >>>>>
> >>>>> Auto generated code should not be added to project. Also most the of
> >>>>> time
> >>>>> ,people who dive into carbondata may not touch format code.
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> View this message in context: http://apache-carbondata-
> >>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
> >>>>> advise-on-building-thrift-files-tp2952p2957.html
> >>>>> Sent from the Apache CarbonData Mailing List archive mailing list
> >>>>> archive
> >>>>> at Nabble.com.
> >>>>>
> >>>>>
> >>>
> >>> --
> >>> Thanks & Regards,
> >>> Ravi
> >>>
> >>
> >>
> >>
> >>
> >> ------------------------------------------------------------
> >> ---------------------------------------
> >> Confidentiality Notice: The information contained in this e-mail and any
> >> accompanying attachment(s)
> >> is intended only for the use of the intended recipient and may be
> >> confidential and/or privileged of
> >> Neusoft Corporation, its subsidiaries and/or its affiliates. If any
> reader
> >> of this communication is
> >> not the intended recipient, unauthorized use, forwarding, printing,
> >> storing, disclosure or copying
> >> is strictly prohibited, and may be unlawful.If you have received this
> >> communication in error,please
> >> immediately notify the sender by return e-mail, and delete the original
> >> message and all copies from
> >> your system. Thank you.
> >> ------------------------------------------------------------
> >> ---------------------------------------
> >>
>
>