Hi
Please find our thoughts on the guidelines we can follow in the community to ensure the quality of Carbondata and make the community more collaborative. Let us discuss here. 1. Let us discuss all the features in the community before starting design. Let us attach the design document in the JIRA for future easy reference 2. Let us have design review meetings for all new features and wait till at least 3 committers give +1 and approve the design. 3. Let us do the impact analysis on base flows and share our analysis along with the design review. 4. Let us wait for at least 2 committers to review our code and put LGTM. 5. Let us discuss and assign release manager role to one of the committers/PMCs for every version and empower the release manager to actively track the PRs required for the release scope and also assign the review owners for them so that PRs are merged timely. 6. Let us have weekly meetings for all important features and let the feature developers/owners share the progress and other developments. 7. Let us attach functional, compatibility and performance comparison [TPCH] reports both in JIRA and PR for all feature requirements 8. Let us develop features or optimizations not aligned with the release scope in a separate branch. 9. Let us add the mailing list link to the Jira to ensure easy tracking. Suggest checking all the open Jira before proposing new features or enhancements. 10. Let us add the JIRA link in the mailing list to ensure easy tracking. -- Thanks & Regards, Ravindra |
Administrator
|
Hi
Thanks for starting the discussion. Big big +1 from my side, these rules are ASF key concepts (community over code, open and enough communition etc.), i do believe, these rules will help Apache CarbonData community go far! Regards Liang ravipesala wrote > Hi > > Please find our thoughts on the guidelines we can follow in the community > to ensure the quality of Carbondata and make the community more > collaborative. Let us discuss here. > > > 1. Let us discuss all the features in the community before starting > design. Let us attach the design document in the JIRA for future easy > reference > > 2. Let us have design review meetings for all new features and wait > till > at least 3 committers give +1 and approve the design. > > 3. Let us do the impact analysis on base flows and share our analysis > along with the design review. > > 4. Let us wait for at least 2 committers to review our code and put > LGTM. > > 5. Let us discuss and assign release manager role to one of the > committers/PMCs for every version and empower the release manager to > actively track the PRs required for the release scope and also assign the > review owners for them so that PRs are merged timely. > > 6. Let us have weekly meetings for all important features and let the > feature developers/owners share the progress and other > developments. > > 7. Let us attach functional, compatibility and performance comparison > [TPCH] reports both in JIRA and PR for all feature requirements > > 8. Let us develop features or optimizations not aligned with the > release > scope in a separate branch. > > 9. Let us add the mailing list link to the Jira to ensure easy > tracking. > Suggest checking all the open Jira before proposing new features or > enhancements. > > 10. Let us add the JIRA link in the mailing list to ensure easy tracking. > > -- > > Thanks & Regards, > Ravindra -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/ |
In reply to this post by ravipesala
+1 for 1,2,3,4,5,8,9,10
+0 for 6,7 ----- Best Regards David Cai -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
Best Regards
David Cai |
In reply to this post by ravipesala
+1
For Point 7 if there is a Automated report that can daily run and share the impact due to daily PR raised and report it to the committer could be efficient. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/ |
In reply to this post by ravipesala
+1 for 1,2,3,4,5,7,8,9,10.
+0 for 6. One suggestion for 7, it better to give a performance comparison [TPCH] report for each release version. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/ |
In reply to this post by ravipesala
Hi ravin, Very nice to see this proposal in community!
The guidelines are better if they are easy to be performed. Even though I care more about the code quality, I do also care about the convenience for developers to contribute. After I go through the points, I think 1,3,5,8,9,10 : +1 2,4,6: How will the meeting be held? What if some committers are not convenient to attend online? As for enough ‘+1’, how can this be ensured to not take too much time? 7: This can be meld into 1,2 |
Dear xuchuanyin,
For 2,4,6-- there are many ways the meeting can be held. Using zoom.us is one mechanism. It is a community collaborative development and hence collective responsibility of all committers. Version manager can remind for timely handling of pr 7 can't be combined with 1,2. 1,2 is activity before starting coding. 7 is test report after coding On Mon, 19 Nov 2018, 9:10 am xuchuanyin, <[hidden email]> wrote: > Hi ravin, Very nice to see this proposal in community! > The guidelines are better if they are easy to be performed. Even though I > care more about the code quality, I do also care about the convenience for > developers to contribute. > > After I go through the points, I think > 1,3,5,8,9,10 : +1 > 2,4,6: How will the meeting be held? What if some committers are not > convenient to attend online? As for enough ‘+1’, how can this be ensured to > not take too much time? > 7: This can be meld into 1,2 > > > > |
In reply to this post by ravipesala
+1, for 1,2,3,4,5,6,8,9,10
for 7, can we support do some test automatic? including performance for common function. It's great for CarbonData community, Can we arrange someone or manager to manage all JIRA and PR, and urge reviewer to review fast. The time will become slower after add these rules, we should accelerate the speed from raise a jira/PR to merge -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/ |
Free forum by Nabble | Edit this page |