[jira] [Commented] (CARBONDATA-198) Implementing system level lock for compaction.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454658#comment-15454658 ]

ASF GitHub Bot commented on CARBONDATA-198:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/116#discussion_r77128213
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -297,15 +366,144 @@ object CarbonDataRDDFactory extends Logging {
         }
         else {
           logger
    -        .audit("Not able to acquire the compaction lock for table " +
    +        .audit("Not able to acquire the system level compaction lock for table " +
               s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}"
             )
           logger
             .error("Not able to acquire the compaction lock for table " + carbonLoadModel
               .getDatabaseName + "." + carbonLoadModel.getTableName
             )
    -      sys.error("Table is already locked for compaction. Please try after some time.")
    +      if (!CarbonCompactionUtil
    +        .createCompactionRequiredFile(carbonTable.getMetaDataFilepath, compactionType)) {
    +        logger.error("Not able to create a compaction required file for table " + carbonLoadModel
    +          .getDatabaseName + "." + carbonLoadModel.getTableName
    +        )
    +      }
    +      else {
    +        logger
    +          .info("successfully created a compaction required file for table " + carbonLoadModel
    +            .getDatabaseName + "." + carbonLoadModel.getTableName
    +          )
    +      }
    +      sys.error("System is already locked for compaction. Please try after some time.")
    --- End diff --
   
    change message to "Compaction is in progress, compaction request for table "" in queue".
    Print error only during ddl trigger.

> Implementing system level lock for compaction.
> ----------------------------------------------
>
>                 Key: CARBONDATA-198
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-198
>             Project: CarbonData
>          Issue Type: Bug
>          Components: spark-integration
>            Reporter: ravikiran
>
> 1. making DDL of compaction as blocking call.
> 2. implemented System level compaction locking. only one compaction allowed , other requests will create compaction request file.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)