[jira] [Commented] (CARBONDATA-198) Implementing system level lock for compaction.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454689#comment-15454689 ]

ASF GitHub Bot commented on CARBONDATA-198:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/116#discussion_r77129488
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -400,43 +631,36 @@ object CarbonDataRDDFactory extends Logging {
                 compactionLock.unlock()
               }
             }
    -      }.start
    +      }
    +      if(compactionModel.isDDLTrigger) {
    +        // making this an blocking call for DDL
    +        compactionThread.run()
    +      }
    +      else {
    +        // non blocking call in case of auto compaction.
    +        compactionThread.start()
    +      }
         }
         else {
           compactionLock.unlock()
    --- End diff --
   
    check if any exception is possible , if needed to be moved to finally

> Implementing system level lock for compaction.
> ----------------------------------------------
>
>                 Key: CARBONDATA-198
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-198
>             Project: CarbonData
>          Issue Type: Bug
>          Components: spark-integration
>            Reporter: ravikiran
>
> 1. making DDL of compaction as blocking call.
> 2. implemented System level compaction locking. only one compaction allowed , other requests will create compaction request file.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)