[jira] [Commented] (CARBONDATA-214) The binary file need be removed under core/src/test/resources/part-xxx

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510417#comment-15510417 ]

ASF GitHub Bot commented on CARBONDATA-214:
-------------------------------------------

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/179#discussion_r79872943
 
    --- Diff: processing/src/test/java/org/apache/carbondata/test/util/StoreCreator.java ---
    @@ -0,0 +1,565 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.test.util;
    +
    +import java.io.BufferedReader;
    +import java.io.BufferedWriter;
    +import java.io.DataOutputStream;
    +import java.io.File;
    +import java.io.FileReader;
    +import java.io.IOException;
    +import java.io.OutputStreamWriter;
    +import java.nio.charset.Charset;
    +import java.text.SimpleDateFormat;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +import java.util.UUID;
    +
    +import org.apache.carbondata.core.cache.Cache;
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.cache.dictionary.Dictionary;
    +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier;
    +import org.apache.carbondata.core.carbon.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.carbon.CarbonDataLoadSchema;
    +import org.apache.carbondata.core.carbon.CarbonTableIdentifier;
    +import org.apache.carbondata.core.carbon.ColumnIdentifier;
    +import org.apache.carbondata.core.carbon.metadata.CarbonMetadata;
    +import org.apache.carbondata.core.carbon.metadata.converter.SchemaConverter;
    +import org.apache.carbondata.core.carbon.metadata.converter.ThriftWrapperSchemaConverterImpl;
    +import org.apache.carbondata.core.carbon.metadata.datatype.DataType;
    +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolution;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolutionEntry;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.CarbonTable;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableInfo;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableSchema;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonColumn;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonDimension;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonMeasure;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.ColumnSchema;
    +import org.apache.carbondata.core.carbon.path.CarbonStorePath;
    +import org.apache.carbondata.core.carbon.path.CarbonTablePath;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastorage.store.impl.FileFactory;
    +import org.apache.carbondata.core.load.BlockDetails;
    +import org.apache.carbondata.core.load.LoadMetadataDetails;
    +import org.apache.carbondata.core.util.CarbonProperties;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriter;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriterImpl;
    +import org.apache.carbondata.core.writer.ThriftWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriterImpl;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfo;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfoPreparator;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperations;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperationsImpl;
    +import org.apache.carbondata.lcm.fileoperations.FileWriteOperation;
    +import org.apache.carbondata.processing.api.dataloader.DataLoadModel;
    +import org.apache.carbondata.processing.api.dataloader.SchemaInfo;
    +import org.apache.carbondata.processing.csvload.DataGraphExecuter;
    +import org.apache.carbondata.processing.dataprocessor.DataProcessTaskStatus;
    +import org.apache.carbondata.processing.dataprocessor.IDataProcessStatus;
    +import org.apache.carbondata.processing.graphgenerator.GraphGenerator;
    +import org.apache.carbondata.processing.graphgenerator.GraphGeneratorException;
    +import org.apache.carbondata.processing.util.CarbonDataProcessorUtil;
    +
    +import com.google.gson.Gson;
    +
    +/**
    + * This class will create store file based on provided schema
    + *
    + * @author Administrator
    --- End diff --
   
    please remove "@author Administrator"

> The binary file need be removed under core/src/test/resources/part-xxx
> ----------------------------------------------------------------------
>
>                 Key: CARBONDATA-214
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-214
>             Project: CarbonData
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.2.0-incubating, 0.1.1-incubating
>            Reporter: ChenLiang
>            Priority: Minor
>             Fix For: 0.2.0-incubating, 0.1.1-incubating
>
>
> The binary file need be removed under core/src/test/resources/part-xxx, need to auto-generate the binary file while running test case

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)