[jira] [Commented] (CARBONDATA-244) Load and delete segment by id queries giving inconsistent results when we execute parallely

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CARBONDATA-244) Load and delete segment by id queries giving inconsistent results when we execute parallely

Akash R Nilugal (Jira)

    [ https://issues.apache.org/jira/browse/CARBONDATA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496970#comment-15496970 ]

ASF GitHub Bot commented on CARBONDATA-244:
-------------------------------------------

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/156#discussion_r79222066
 
    --- Diff: processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java ---
    @@ -306,13 +330,18 @@ private Integer compareDateValues(Long loadValue, Long userValue) {
        * @return
        */
       public List<String> updateDeletionStatus(String loadDate, String tableFolderPath,
    -      Long loadStartTime) {
    -    ICarbonLock carbonLock = CarbonLockFactory
    -        .getCarbonLockObj(absoluteTableIdentifier.getCarbonTableIdentifier(),
    -            LockUsage.METADATA_LOCK);
    +      Long loadStartTime) throws Exception {
    +    CarbonTableIdentifier carbonTableIdentifier =
    +        absoluteTableIdentifier.getCarbonTableIdentifier();
    +    ICarbonLock carbonMetadataLock =
    +        CarbonLockFactory.getCarbonLockObj(carbonTableIdentifier, LockUsage.METADATA_LOCK);
    +    ICarbonLock carbonTableStatusLock =
    +        CarbonLockFactory.getCarbonLockObj(carbonTableIdentifier, LockUsage.TABLE_STATUS_LOCK);
    +    String tableDetails =
    +        carbonTableIdentifier.getDatabaseName() + "." + carbonTableIdentifier.getTableName();
         List<String> invalidLoadTimestamps = new ArrayList<String>(0);
         try {
    -      if (carbonLock.lockWithRetries()) {
    +      if (carbonMetadataLock.lockWithRetries()) {
    --- End diff --
   
    ok


> Load and delete segment by id queries giving inconsistent results when we execute parallely
> -------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-244
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-244
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Manohar Vanam
>            Assignee: Manohar Vanam
>
> Delete segment by id behavior is inconsistent when  we Execute load and delete segment by id queries parallely,  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)