[jira] [Commented] (CARBONDATA-244) Load and delete segment by id queries giving inconsistent results when we execute parallely

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CARBONDATA-244) Load and delete segment by id queries giving inconsistent results when we execute parallely

Akash R Nilugal (Jira)

    [ https://issues.apache.org/jira/browse/CARBONDATA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499620#comment-15499620 ]

ASF GitHub Bot commented on CARBONDATA-244:
-------------------------------------------

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/156#discussion_r79291255
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -1111,25 +1131,32 @@ object CarbonDataRDDFactory extends Logging {
         val table = org.apache.carbondata.core.carbon.metadata.CarbonMetadata.getInstance
           .getCarbonTable(carbonLoadModel.getDatabaseName + "_" + carbonLoadModel.getTableName)
         val metaDataPath: String = table.getMetaDataFilepath
    -    val carbonLock = CarbonLockFactory
    +    val carbonCleanFilesLock = CarbonLockFactory
           .getCarbonLockObj(table.getAbsoluteTableIdentifier.getCarbonTableIdentifier,
    -        LockUsage.METADATA_LOCK
    +        LockUsage.CLEAN_FILES_LOCK
           )
         try {
    -      if (carbonLock.lockWithRetries()) {
    +      if (carbonCleanFilesLock.lockWithRetries()) {
    +        logger.info("Clean files lock has been successfully acquired.")
             deleteLoadsAndUpdateMetadata(carbonLoadModel,
               table,
               partitioner,
               hdfsStoreLocation,
               isForceDeletion = true)
           }
    +      else {
    +        val errorMsg = "Clean files request is failed for " + carbonLoadModel.getDatabaseName +
    --- End diff --
   
     "Clean file request is running in the background, please try after some time". u[date the comment since already we know the operation


> Load and delete segment by id queries giving inconsistent results when we execute parallely
> -------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-244
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-244
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Manohar Vanam
>            Assignee: Manohar Vanam
>
> Delete segment by id behavior is inconsistent when  we Execute load and delete segment by id queries parallely,  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)