[jira] [Commented] (CARBONDATA-246) compaction is wrong in case if last segment is not assigned to an executor.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498922#comment-15498922 ]

ASF GitHub Bot commented on CARBONDATA-246:
-------------------------------------------

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/161#discussion_r79282917
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala ---
    @@ -69,7 +69,9 @@ object Compactor {
           schemaName,
           factTableName,
           validSegments,
    -      carbonTable.getAbsoluteTableIdentifier.getCarbonTableIdentifier.getTableId
    +      carbonTable.getAbsoluteTableIdentifier.getCarbonTableIdentifier.getTableId,
    +      colCardinality = Array[Int](0),
    --- End diff --
   
    Instead of creating an empty list and reassigning it you can create a reference of Array[Int] type like
    var colCardinality: Array[Int] = null

>  compaction is wrong in case if last segment is not assigned to an executor.
> ----------------------------------------------------------------------------
>
>                 Key: CARBONDATA-246
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-246
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: ravikiran
>
> if during compaction of 4 loads, for any executor if only first 3 loads task is assigned then the col cardinality calculation based on the last segment info will become wrong.
> in this case the cardinality will go wrong for that executor.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)