[jira] [Commented] (CARBONDATA-246) compaction is wrong in case if last segment is not assigned to an executor.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499476#comment-15499476 ]

ASF GitHub Bot commented on CARBONDATA-246:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/161#discussion_r79289289
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala ---
    @@ -102,6 +102,11 @@ class CarbonMergerRDD[K, V](
             var dataloadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
             val carbonSparkPartition = theSplit.asInstanceOf[CarbonSparkPartition]
     
    +        // get destination segment properties as sent from driver which is of last segment.
    +
    +        val segmentProperties = new SegmentProperties(carbonMergerMapping.columnSchemaList.asJava,
    --- End diff --
   
    rename it to maxSegmentcolumnSchemaList and maxSegmentColCardinality.
    Write comment where it is declared

>  compaction is wrong in case if last segment is not assigned to an executor.
> ----------------------------------------------------------------------------
>
>                 Key: CARBONDATA-246
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-246
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: ravikiran
>
> if during compaction of 4 loads, for any executor if only first 3 loads task is assigned then the col cardinality calculation based on the last segment info will become wrong.
> in this case the cardinality will go wrong for that executor.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)