[jira] [Commented] (CARBONDATA-251) making the auto compaction as blocking call.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499300#comment-15499300 ]

ASF GitHub Bot commented on CARBONDATA-251:
-------------------------------------------

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/168#discussion_r79287305
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -1030,28 +1021,36 @@ object CarbonDataRDDFactory extends Logging {
             logWarning("Cannot write load metadata file as data load failed")
             throw new Exception(errorMessage)
           } else {
    -        val metadataDetails = status(0)._2
    -        if (!isAgg) {
    -          val status = CarbonLoaderUtil
    -            .recordLoadMetadata(currentLoadCount,
    -              metadataDetails,
    -              carbonLoadModel,
    -              loadStatus,
    -              loadStartTime
    -            )
    -          if (!status) {
    -            val errorMessage = "Dataload failed due to failure in table status updation."
    -            logger.audit("Data load is failed for " +
    -              s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}")
    -            logger.error("Dataload failed due to failure in table status updation.")
    -            throw new Exception(errorMessage)
    +          val metadataDetails = status(0)._2
    +          if (!isAgg) {
    +            val status = CarbonLoaderUtil
    +              .recordLoadMetadata(currentLoadCount,
    +                metadataDetails,
    +                carbonLoadModel,
    +                loadStatus,
    +                loadStartTime
    +              )
    +            if (!status) {
    +              val errorMessage = "Dataload failed due to failure in table status updation."
    +              logger.audit("Data load is failed for " +
    +                           s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}")
    +              logger.error("Dataload failed due to failure in table status updation.")
    +              throw new Exception(errorMessage)
    +            }
    +          } else if (!carbonLoadModel.isRetentionRequest) {
    +            // TODO : Handle it
    +            logInfo("********Database updated**********")
               }
    -        } else if (!carbonLoadModel.isRetentionRequest) {
    -          // TODO : Handle it
    -          logInfo("********Database updated**********")
    +          logger.audit("Data load is successful for " +
    +                       s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}")
    +        try {
    +          // compaction handling
    +          handleSegmentMerging(tableCreationTime)
    +        }
    +        catch {
    +          case e: Exception =>
    +            throw new Exception("Dataload is success. Compaction is failed. Please check logs.")
    --- End diff --
   
    fixed

> making the auto compaction as blocking call.
> --------------------------------------------
>
>                 Key: CARBONDATA-251
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-251
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: ravikiran
>
> making the auto compaction as blocking call.
> disabling the system level compaction lock feature.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)