[
https://issues.apache.org/jira/browse/CARBONDATA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500927#comment-15500927 ]
ASF GitHub Bot commented on CARBONDATA-256:
-------------------------------------------
GitHub user vinodkc opened a pull request:
https://github.com/apache/incubator-carbondata/pull/173 [CARBONDATA-256]Changed StringBuffer to StringBuilder
Even with local variables of Stringbuffer type, unnecessary synchronization overhead will be added in string operation.Replacing StringBuffer with StringBuilder in such cases can avoid synchronization overhead
- Whether new unit test cases have been added or why no new tests are required?
>> Not added new TCs . Not modified any new functional change
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/vinodkc/incubator-carbondata changeStringBufferToStringBuilder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/173.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 5401b825efad5ad650a06a9907c0e771e706ed5b
Author: vinodkc <
[hidden email]>
Date: 2016-09-18T12:18:44Z
Changed StringBuffer to StringBuilder
----
> Replace StringBuffer with StringBuilder in case of local variables
> ------------------------------------------------------------------
>
> Key: CARBONDATA-256
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-256> Project: CarbonData
> Issue Type: Improvement
> Reporter: Vinod KC
> Priority: Trivial
>
> Even with local variables of Stringbuffer type, unnecessary synchronization overhead will be added in string operation.Replacing StringBuffer with StringBuilder in such cases can avoid synchronization overhead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
