[jira] [Commented] (CARBONDATA-267) Set block_size for table on table level

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515287#comment-15515287 ]

ASF GitHub Bot commented on CARBONDATA-267:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/189#discussion_r80177385
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -124,6 +124,7 @@ struct TableSchema{
      1: required string table_id;  // ID used to
      2: required list<ColumnSchema> table_columns; // Columns in the table
      3: required SchemaEvolution schema_evolution; // History of schema evolution of this table
    + 4: optional i32 block_size
    --- End diff --
   
    I think it is better to save it in the table metadata, through metastore for example.
    By concept, this should not be tied with the file.
    @ravipesala @gvramana any suggestion?

> Set block_size for table on table level
> ---------------------------------------
>
>                 Key: CARBONDATA-267
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-267
>             Project: CarbonData
>          Issue Type: New Feature
>    Affects Versions: 0.1.0-incubating
>            Reporter: zhangshunyu
>            Assignee: zhangshunyu
>             Fix For: 0.2.0-incubating
>
>
> Set block_size for table on table level

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)