[jira] [Commented] (CARBONDATA-267) Set block_size for table on table level

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535073#comment-15535073 ]

ASF GitHub Bot commented on CARBONDATA-267:
-------------------------------------------

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/189#discussion_r81279790
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -124,6 +124,7 @@ struct TableSchema{
      1: required string table_id;  // ID used to
      2: required list<ColumnSchema> table_columns; // Columns in the table
      3: required SchemaEvolution schema_evolution; // History of schema evolution of this table
    + 4: optional i32 block_size
    --- End diff --
   
    @Zhangshunyu ...I agree with @jackylk ...just like we are storing the table path in metastore, same way block size can also be stored as it is metadata for the table. schema file we write should only describe the structure the table and not the metadata for table

> Set block_size for table on table level
> ---------------------------------------
>
>                 Key: CARBONDATA-267
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-267
>             Project: CarbonData
>          Issue Type: New Feature
>    Affects Versions: 0.1.0-incubating
>            Reporter: zhangshunyu
>            Assignee: zhangshunyu
>             Fix For: 0.2.0-incubating
>
>
> Set block_size for table on table level

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)