[jira] [Commented] (CARBONDATA-267) Set block_size for table on table level

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535550#comment-15535550 ]

ASF GitHub Bot commented on CARBONDATA-267:
-------------------------------------------

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/189#discussion_r81308653
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -546,6 +548,30 @@ class CarbonSqlParser()
         colGrpNames.toString()
       }
     
    +  protected def getTableBlockSize(tableProperties: Map[String, String]): Integer = {
    +    var tableBlockSize: Integer = 0
    +    if (tableProperties.get(CarbonCommonConstants.TABLE_BLOCKSIZE).isDefined) {
    +      val blockSizeStr: String = tableProperties.get(CarbonCommonConstants.TABLE_BLOCKSIZE).get
    +      try {
    +        tableBlockSize = Integer.parseInt(blockSizeStr)
    +      } catch {
    +        case e: NumberFormatException =>
    +          throw new MalformedCarbonCommandException("Invalid table_blocksize value found: " +
    +            s"$blockSizeStr, only int value from 1 to 2048 is supported.")
    +      }
    +      if (tableBlockSize < CarbonCommonConstants.BLOCK_SIZE_MIN_VAL ||
    +        tableBlockSize > CarbonCommonConstants.BLOCK_SIZE_MAX_VAL) {
    +        throw new MalformedCarbonCommandException("Invalid table_blocksize value found: " +
    +          s"$blockSizeStr, only int value from 1 to 2048 is supported.")
    --- End diff --
   
    Please mention the Unit also in comment like GB or MB
    "Invalid table_blocksize value found: " +
     +          s"$blockSizeStr, only int value from 1 MB to 2048 MB is supported"

> Set block_size for table on table level
> ---------------------------------------
>
>                 Key: CARBONDATA-267
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-267
>             Project: CarbonData
>          Issue Type: New Feature
>    Affects Versions: 0.1.0-incubating
>            Reporter: zhangshunyu
>            Assignee: zhangshunyu
>             Fix For: 0.2.0-incubating
>
>
> Set block_size for table on table level

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)