[jira] [Commented] (CARBONDATA-268) CarbonOptimizer has performance problem

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516078#comment-15516078 ]

ASF GitHub Bot commented on CARBONDATA-268:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/190#discussion_r80219989
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala ---
    @@ -68,9 +70,50 @@ object CarbonOptimizer {
      */
     class ResolveCarbonFunctions(relations: Seq[CarbonDecoderRelation])
       extends Rule[LogicalPlan] with PredicateHelper {
    -
    +  val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
       def apply(plan: LogicalPlan): LogicalPlan = {
    -    transformCarbonPlan(plan, relations)
    +    if (relations.nonEmpty && !isOptimized(plan)) {
    +      LOGGER.info("Starting to optimize plan")
    +      val startTime = System.currentTimeMillis
    +      val result = transformCarbonPlan(plan, relations)
    +      LOGGER.info("Time taken to optimize plan: " + ( System.currentTimeMillis - startTime))
    --- End diff --
   
    change the statement to "Time taken for Carbon Optimizer to optimize"

> CarbonOptimizer has performance problem
> ---------------------------------------
>
>                 Key: CARBONDATA-268
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-268
>             Project: CarbonData
>          Issue Type: Bug
>    Affects Versions: 0.1.0-incubating
>            Reporter: QiangCai
>
> 1. invoke relation lookup many times
> 2. lookup list many times

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)