[jira] [Commented] (CARBONDATA-269) Change delete segment parser because its may confused with hive grammar

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515630#comment-15515630 ]

ASF GitHub Bot commented on CARBONDATA-269:
-------------------------------------------

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/192#discussion_r80060992
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1181,23 +1182,21 @@ class CarbonSqlParser()
             p.getClass.getSimpleName.equals("DecimalLit") } ) ^^ (_.chars)
     
       protected lazy val deleteLoadsByID: Parser[LogicalPlan] =
    -    DELETE ~> SEGMENT ~> repsep(segmentId, ",") ~ (FROM ~> TABLE ~>
    -      (ident <~ ".").? ~ ident) <~
    +    DELETE ~> FROM ~ TABLE ~> (ident <~ ".").? ~ ident ~
    +      (WHERE ~> SEGMENT ~> EQUAL ~> repsep(segmentId, ",")) <~
    --- End diff --
   
    I think its better to use segments in both places deleteLoadsByID , deleteLoadsByLoadDate to avoid confusion

> Change delete segment parser because its may confused with hive grammar
> -----------------------------------------------------------------------
>
>                 Key: CARBONDATA-269
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-269
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Jay
>            Priority: Minor
>
> the delete segment grammar in carbon is too similar with that delete grammar in hive,  while they have different usage. so change carbon's grammar to make carbon easy use.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)