[jira] [Commented] (CARBONDATA-297) 2. Add interfaces for data loading.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574308#comment-15574308 ]

ASF GitHub Bot commented on CARBONDATA-297:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/229#discussion_r83354231
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java ---
    @@ -73,15 +72,15 @@ public AbstractDataLoadProcessorStep(CarbonDataLoadConfiguration configuration,
        * Create the iterator using child iterator.
        *
        * @param childIter
    -   * @return
    +   * @return new iterator with step specific processing.
        */
    -  protected Iterator<Object[]> getIterator(final Iterator<Object[]> childIter) {
    -    return new CarbonIterator<Object[]>() {
    +  protected Iterator<CarbonRow> getIterator(final Iterator<CarbonRow> childIter) {
    --- End diff --
   
    In order to support batch conversion, it is better to put `Iterator<CarbonRow[]>` instead

> 2. Add interfaces for data loading.
> -----------------------------------
>
>                 Key: CARBONDATA-297
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-297
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add the major interface classes for data loading so that the following jiras can use this interfaces to implement it.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)