[
https://issues.apache.org/jira/browse/CARBONDATA-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591096#comment-15591096 ]
ASF GitHub Bot commented on CARBONDATA-298:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/240#discussion_r84226906
--- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java ---
@@ -114,11 +114,15 @@ protected CarbonRowBatch processRowBatch(CarbonRowBatch rowBatch) {
/**
* It is called when task is called successfully.
*/
- public abstract void finish();
+ public void finish() {
+ // implementation classes can override to update the status.
+ }
/**
* Closing of resources after step execution can be done here.
*/
- public abstract void close();
+ public void close() {
+ // implementation classes can override to close the resources if any available.
--- End diff --
The comment is not so clear, is this called in case of failure?
in `finish()`, resources also need to be released, right?
> 3. Add InputProcessorStep which should iterate recordreader and parse the data as per the data type.
> ----------------------------------------------------------------------------------------------------
>
> Key: CARBONDATA-298
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-298> Project: CarbonData
> Issue Type: Sub-task
> Reporter: Ravindra Pesala
> Fix For: 0.2.0-incubating
>
>
> Add InputProcessorStep which should iterate recordreader/RecordBufferedWriter and parse the data as per the data types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
