[jira] [Commented] (CARBONDATA-300) 5. Add EncodeProcessorStep which encodes the data with dictionary.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595223#comment-15595223 ]

ASF GitHub Bot commented on CARBONDATA-300:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484027
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/FieldEncoderFactory.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.processing.newflow.converter.impl;
    +
    +import org.apache.carbondata.core.cache.Cache;
    +import org.apache.carbondata.core.cache.dictionary.Dictionary;
    +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier;
    +import org.apache.carbondata.core.carbon.CarbonTableIdentifier;
    +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding;
    +import org.apache.carbondata.processing.newflow.DataField;
    +import org.apache.carbondata.processing.newflow.converter.FieldConverter;
    +
    +public class FieldEncoderFactory {
    +
    +  private static FieldEncoderFactory instance;
    +
    +  private FieldEncoderFactory() {
    +
    +  }
    +
    +  public static FieldEncoderFactory getInstance() {
    +    if (instance == null) {
    +      instance = new FieldEncoderFactory();
    +    }
    +    return instance;
    +  }
    +
    +  public FieldConverter createFieldEncoder(DataField dataField,
    +      Cache<DictionaryColumnUniqueIdentifier, Dictionary> cache,
    +      CarbonTableIdentifier carbonTableIdentifier, int index) {
    +    if (dataField.hasDictionaryEncoding()) {
    +      return new DictionaryFieldConverterImpl(dataField, cache, carbonTableIdentifier, index);
    +    } else if (dataField.getColumn().hasEncoding(Encoding.DIRECT_DICTIONARY)) {
    +      return new DirectDictionaryFieldConverterImpl(dataField, index);
    +    } else if (dataField.getColumn().isComplex()) {
    +      return new ComplexFieldConverterImpl();
    +    } else if ((dataField.getColumn().hasEncoding(Encoding.DICTIONARY) ||
    --- End diff --
   
    this else if seems redundant, its condition is covered in previous if?

> 5. Add EncodeProcessorStep which encodes the data with dictionary.
> ------------------------------------------------------------------
>
>                 Key: CARBONDATA-300
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-300
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add EncodeProcessorStep which encodes the data with dictionary.This dictionary can be obtained from dictionary interface.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)