[jira] [Commented] (CARBONDATA-300) 5. Add EncodeProcessorStep which encodes the data with dictionary.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595225#comment-15595225 ]

ASF GitHub Bot commented on CARBONDATA-300:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/244#discussion_r84484170
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java ---
    @@ -0,0 +1,99 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.processing.newflow.converter.impl;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.cache.Cache;
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.cache.dictionary.Dictionary;
    +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier;
    +import org.apache.carbondata.core.util.CarbonTimeStatisticsFactory;
    +import org.apache.carbondata.processing.newflow.CarbonDataLoadConfiguration;
    +import org.apache.carbondata.processing.newflow.DataField;
    +import org.apache.carbondata.processing.newflow.constants.DataLoadProcessorConstants;
    +import org.apache.carbondata.processing.newflow.converter.FieldConverter;
    +import org.apache.carbondata.processing.newflow.converter.RowConverter;
    +import org.apache.carbondata.processing.newflow.exception.CarbonDataLoadingException;
    +import org.apache.carbondata.processing.newflow.row.CarbonRow;
    +
    +import org.apache.commons.lang3.ArrayUtils;
    +
    +/**
    + * It converts the complete row if necessary, dictionary columns are encoded with dictionary values
    + * and nondictionary values are converted to binary.
    + */
    +public class RowConverterImpl implements RowConverter {
    +
    +  private CarbonDataLoadConfiguration configuration;
    +
    +  private FieldConverter[] fieldConverters;
    +
    +  public RowConverterImpl(DataField[] fields, CarbonDataLoadConfiguration configuration) {
    +    this.configuration = configuration;
    +    CacheProvider cacheProvider = CacheProvider.getInstance();
    +    Cache<DictionaryColumnUniqueIdentifier, Dictionary> cache =
    +        cacheProvider.createCache(CacheType.REVERSE_DICTIONARY,
    +            configuration.getTableIdentifier().getStorePath());
    +    List<FieldConverter> fieldConverterList = new ArrayList<>();
    +
    +    long lruCacheStartTime = System.currentTimeMillis();
    +
    +    for (int i = 0; i < fields.length; i++) {
    +      FieldConverter fieldConverter = FieldEncoderFactory.getInstance()
    +          .createFieldEncoder(fields[i], cache,
    +              configuration.getTableIdentifier().getCarbonTableIdentifier(), i);
    +      if (fieldConverter != null) {
    --- End diff --
   
    ok. only dictionary and no dictionary and complex column has converter, right?
    can we make this code more readable, like checking whether it is non-measure.
    And measure can not be complex column?

> 5. Add EncodeProcessorStep which encodes the data with dictionary.
> ------------------------------------------------------------------
>
>                 Key: CARBONDATA-300
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-300
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add EncodeProcessorStep which encodes the data with dictionary.This dictionary can be obtained from dictionary interface.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)