[ https://issues.apache.org/jira/browse/CARBONDATA-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595782#comment-15595782 ] ASF GitHub Bot commented on CARBONDATA-300: ------------------------------------------- Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/244#discussion_r84518688 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/FieldEncoderFactory.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.carbondata.processing.newflow.converter.impl; + +import org.apache.carbondata.core.cache.Cache; +import org.apache.carbondata.core.cache.dictionary.Dictionary; +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier; +import org.apache.carbondata.core.carbon.CarbonTableIdentifier; +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding; +import org.apache.carbondata.processing.newflow.DataField; +import org.apache.carbondata.processing.newflow.converter.FieldConverter; + +public class FieldEncoderFactory { + + private static FieldEncoderFactory instance; + + private FieldEncoderFactory() { + + } + + public static FieldEncoderFactory getInstance() { + if (instance == null) { + instance = new FieldEncoderFactory(); + } + return instance; + } + + /** + * Creates the FieldConverter for all dimensions, for measures return null. + * @param dataField column schema + * @param cache dicionary cache. + * @param carbonTableIdentifier table identifier + * @param index index of column in the row. + * @return + */ + public FieldConverter createFieldEncoder(DataField dataField, + Cache<DictionaryColumnUniqueIdentifier, Dictionary> cache, + CarbonTableIdentifier carbonTableIdentifier, int index) { + // Converters are only needed for dimensions and measures it return null. + if (dataField.getColumn().isDimesion()) { + if (dataField.hasDictionaryEncoding()) { --- End diff -- Type is already present in column, based on that only we are creating converters here. > 5. Add EncodeProcessorStep which encodes the data with dictionary. > ------------------------------------------------------------------ > > Key: CARBONDATA-300 > URL: https://issues.apache.org/jira/browse/CARBONDATA-300 > Project: CarbonData > Issue Type: Sub-task > Reporter: Ravindra Pesala > Assignee: Ravindra Pesala > Fix For: 0.2.0-incubating > > > Add EncodeProcessorStep which encodes the data with dictionary.This dictionary can be obtained from dictionary interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332) |
Free forum by Nabble | Edit this page |