[jira] [Commented] (CARBONDATA-301) 6. Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595292#comment-15595292 ]

ASF GitHub Bot commented on CARBONDATA-301:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/247#discussion_r84492901
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java ---
    @@ -334,24 +151,24 @@ public void startSorting() throws CarbonSortKeyAndGroupByException {
           toSort = new Object[entryCount][];
           System.arraycopy(recordHolderList, 0, toSort, 0, entryCount);
     
    -      if (noDictionaryCount > 0) {
    -        Arrays.sort(toSort, new RowComparator(noDictionaryDimnesionColumn, noDictionaryCount));
    +      if (parameters.getNoDictionaryCount() > 0) {
    +        Arrays.sort(toSort, new RowComparator(parameters.getNoDictionaryDimnesionColumn(),
    +            parameters.getNoDictionaryCount()));
           } else {
     
    -        Arrays.sort(toSort, new RowComparatorForNormalDims(this.dimColCount));
    +        Arrays.sort(toSort, new RowComparatorForNormalDims(parameters.getDimColCount()));
           }
           recordHolderList = toSort;
     
           // create new file
    -      File file =
    -          new File(this.tempFileLocation + File.separator + this.tableName + System.nanoTime() +
    -              CarbonCommonConstants.SORT_TEMP_FILE_EXT);
    +      File file = new File(
    +          parameters.getTempFileLocation() + File.separator + parameters.getTableName() + System
    --- End diff --
   
    move System to next line

> 6. Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-301
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-301
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)