[jira] [Commented] (CARBONDATA-301) 6. Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595689#comment-15595689 ]

ASF GitHub Bot commented on CARBONDATA-301:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/247#discussion_r84515278
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/CarbonSorter.java ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.processing.newflow.sort;
    +
    +import java.util.Iterator;
    +
    +import org.apache.carbondata.processing.newflow.exception.CarbonDataLoadingException;
    +import org.apache.carbondata.processing.newflow.row.CarbonRowBatch;
    +import org.apache.carbondata.processing.sortandgroupby.sortdata.SortParameters;
    +
    +/**
    + * This interface sorts all the data of iterators.
    + * The life cycle of this interface is initialize -> sort -> close
    + */
    +public interface CarbonSorter {
    --- End diff --
   
    a thread-safe insertRow should work right?
    I think it is not good to couple the pulling logic of CarbonRow and sorting logic. The execution of `Iterator<CarbonRowBatch>[]` should be in `SortProcessorStepImpl.execute()`, while sorting logic should be in Sorter.

> 6. Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-301
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-301
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add SortProcessorStep which sorts the data as per dimension order and write the sorted files to temp location.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)