[
https://issues.apache.org/jira/browse/CARBONDATA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581411#comment-15581411 ]
ASF GitHub Bot commented on CARBONDATA-319:
-------------------------------------------
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/241#discussion_r83584798
--- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java ---
@@ -1237,6 +1237,9 @@ else if(isComplexTypeColumn[j]) {
private void addEntryToBadRecords(Object[] r, int j, String columnName,
String dataType) {
+ if (DataType.LONG.toString().equals(dataType)) {
--- End diff --
This check is not required.
> Bad Records logging for column data type is not proper
> ------------------------------------------------------
>
> Key: CARBONDATA-319
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-319> Project: CarbonData
> Issue Type: Bug
> Reporter: Sujith
> Assignee: Sujith
> Priority: Minor
>
> Bad Records logging for column data type is not proper in case of long, carbon system while creating the table metadata uses BIGINT instead of LONG , internally it converts the bigint to long type and processes , while processing the data if any long type data is having issue it will be logged into the bad record with data type Long which is not proper since as per the metadata the datatype of column is BIGINT.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
