[jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593470#comment-15593470 ]

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84401103
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -175,8 +177,12 @@ object CarbonDataRDDFactory extends Logging {
       }
     
       def configSplitMaxSize(context: SparkContext, filePaths: String,
    -    hadoopConfiguration: Configuration): Unit = {
    -    val defaultParallelism = if (context.defaultParallelism < 1) 1 else context.defaultParallelism
    +      hadoopConfiguration: Configuration): Unit = {
    --- End diff --
   
    in this case, write in one line is ok, no need to modify. better approach is to use min function instead of if else

> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)