[jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593600#comment-15593600 ]

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404340
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala ---
    @@ -385,22 +385,22 @@ class CarbonGlobalDictionaryGenerateRDD(
                   distinctValues)
                 sortIndexWriteTask.execute()
               }
    -          val sortIndexWriteTime = (System.currentTimeMillis() - t4)
    -          CarbonTimeStatisticsFactory.getLoadStatisticsInstance().recordDicShuffleAndWriteTime()
    +          val sortIndexWriteTime = System.currentTimeMillis() - t4
    +          CarbonTimeStatisticsFactory.getLoadStatisticsInstance.recordDicShuffleAndWriteTime()
               // After sortIndex writing, update dictionaryMeta
               dictWriteTask.updateMetaData()
               // clear the value buffer after writing dictionary data
               valuesBuffer.clear
               org.apache.carbondata.core.util.CarbonUtil
    --- End diff --
   
    remove package name

> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)