[
https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593595#comment-15593595 ]
ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404263
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -1114,36 +1121,36 @@ object CarbonDataRDDFactory extends Logging {
if (isUpdationRequired) {
try {
- // Update load metadate file after cleaning deleted nodes
- if (carbonTableStatusLock.lockWithRetries()) {
- logger.info("Table status lock has been successfully acquired.")
+ // Update load metadate file after cleaning deleted nodes
+ if (carbonTableStatusLock.lockWithRetries()) {
+ logger.info("Table status lock has been successfully acquired.")
- // read latest table status again.
- val latestMetadata = segmentStatusManager
- .readLoadMetadata(loadMetadataFilePath)
+ // read latest table status again.
+ val latestMetadata = segmentStatusManager
+ .readLoadMetadata(loadMetadataFilePath)
- // update the metadata details from old to new status.
+ // update the metadata details from old to new status.
- val latestStatus = CarbonLoaderUtil
- .updateLoadMetadataFromOldToNew(details, latestMetadata)
+ val latestStatus = CarbonLoaderUtil
--- End diff --
in this case, move `CarbonLoaderUtil` to next line, do not break the line between object and function
> Improve Code and Fix Warnings
> -----------------------------
>
> Key: CARBONDATA-328
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-328> Project: CarbonData
> Issue Type: Improvement
> Reporter: Prabhat Kashyap
> Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
