[jira] [Commented] (CARBONDATA-366) Incorrect load data behaviour in mentioned scenario

[Akash R Nilugal (Jira)]

    [ https://issues.apache.org/jira/browse/CARBONDATA-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642943#comment-15642943 ]

ASF GitHub Bot commented on CARBONDATA-366:
-------------------------------------------

Github user ashokblend commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/284#discussion_r86708341
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -117,18 +117,27 @@ public static void closeStreams(Closeable... streams) {
         // Added if to avoid NullPointerException in case one stream is being passed as null
         if (null != streams) {
           for (Closeable stream : streams) {
    -        if (null != stream) {
    -          try {
    -            stream.close();
    -          } catch (IOException e) {
    -            LOGGER.error("Error while closing stream" + stream);
    -          }
    +        try {
    +          closeStream(stream);
    +        } catch (IOException e) {
    +          LOGGER.error("Error while closing stream:" + e);
    --- End diff --
   
    This is an optimizaion. This method calls another method which tthrows IOException. During load we call the method which throws IO. Please check my other changes.

> Incorrect load data behaviour in mentioned scenario
> ---------------------------------------------------
>
>                 Key: CARBONDATA-366
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-366
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Ashok Kumar
>            Priority: Minor
>
> In some scenario, when user loads data system shows load is success full but when we query, there is no data.
> When we see at store location, 0 byte file is created for index file.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)