[
https://issues.apache.org/jira/browse/CARBONDATA-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640822#comment-15640822 ]
ASF GitHub Bot commented on CARBONDATA-383:
-------------------------------------------
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/298#discussion_r86676467
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala ---
@@ -166,7 +166,7 @@ class SparkPartitionLoader(model: CarbonLoadModel,
* @param result Output result
* @param carbonLoadModel Carbon load model which contain the load info
* @param storeLocation Tmp store location
- * @param hdfsStoreLocation The store location in hdfs
+ * @param storePath The store location in hdfs
--- End diff --
the comment need change accordingly of "The store location in hdfs"
> Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon not only support hdfs path
> -------------------------------------------------------------------------------------------------
>
> Key: CARBONDATA-383
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-383> Project: CarbonData
> Issue Type: Improvement
> Components: core
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Minor
>
> Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon not only support hdfs path.
> Currently, Carbon can support hdfs/viewfs schema and alluxio will be later, ref [CARBONDATA-367|
https://issues.apache.org/jira/browse/CARBONDATA-367]. So change parameters' name (hdfsStoreLocation/hdfsStorePath) to storePath in order to avoid ambiguity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
