[jira] [Updated] (CARBONDATA-1071) test cases of TestSortColumns class will never fails

[Akash R Nilugal (Jira)]

     [ https://issues.apache.org/jira/browse/CARBONDATA-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

anubhav tarar updated CARBONDATA-1071:
--------------------------------------
    Request participants:   (was: )
             Description:
 test("create table with direct-dictioanry sort_columns") {

    sql("CREATE TABLE sorttable3 (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' ")

    sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable3 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")

    sql("select doj from sorttable3").show()

    sql("select doj from sorttable3 order by doj").show()

    checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj"))
  }

result:
+--------------------+
|                 doj|
+--------------------+
|2010-12-29 00:00:...|
|2007-01-17 00:00:...|
|2011-11-09 00:00:...|
|2015-12-01 00:00:...|
|2013-09-22 00:00:...|
|2008-05-29 00:00:...|
|2009-07-07 00:00:...|
|2012-10-14 00:00:...|
|2015-05-12 00:00:...|
|2014-08-15 00:00:...|
+--------------------+

|                 doj|
+--------------------+
|2007-01-17 00:00:...|
|2008-05-29 00:00:...|
|2009-07-07 00:00:...|
|2010-12-29 00:00:...|
|2011-11-09 00:00:...|
|2012-10-14 00:00:...|
|2013-09-22 00:00:...|
|2014-08-15 00:00:...|
|2015-05-12 00:00:...|
|2015-12-01 00:00:...|
+--------------------+

result of test case it passed ,but it should fail

checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj")

this check is only validating the data not the order of data the real purpose for which sort column is used

to make sure we are able to verify the functionality of sort columns it test cases must be modified

  was:
 test("create table with direct-dictioanry sort_columns") {

    sql("CREATE TABLE sorttable3 (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' ")

    sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable3 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
    sql("select doj from sorttable3").show()
    sql("select doj from sorttable3 order by doj").show()
    checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj"))
  }

result:
+--------------------+
|                 doj|
+--------------------+
|2010-12-29 00:00:...|
|2007-01-17 00:00:...|
|2011-11-09 00:00:...|
|2015-12-01 00:00:...|
|2013-09-22 00:00:...|
|2008-05-29 00:00:...|
|2009-07-07 00:00:...|
|2012-10-14 00:00:...|
|2015-05-12 00:00:...|
|2014-08-15 00:00:...|
+--------------------+

|                 doj|
+--------------------+
|2007-01-17 00:00:...|
|2008-05-29 00:00:...|
|2009-07-07 00:00:...|
|2010-12-29 00:00:...|
|2011-11-09 00:00:...|
|2012-10-14 00:00:...|
|2013-09-22 00:00:...|
|2014-08-15 00:00:...|
|2015-05-12 00:00:...|
|2015-12-01 00:00:...|
+--------------------+

result of test case it passed ,but it should fail

checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj")

this check is only validating the data not the order of data the real purpose for which sort column is used

to make sure we are able to verify the functionality of sort columns it test cases must be modified

> test cases of TestSortColumns class will never fails
> -----------------------------------------------------
>
>                 Key: CARBONDATA-1071
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-1071
>             Project: CarbonData
>          Issue Type: Bug
>          Components: spark-integration
>    Affects Versions: 1.1.0
>         Environment: test
>            Reporter: SWATI RAO
>             Fix For: 1.1.0
>
>
>  test("create table with direct-dictioanry sort_columns") {
>     sql("CREATE TABLE sorttable3 (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' ")
>     sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable3 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
>     sql("select doj from sorttable3").show()
>     sql("select doj from sorttable3 order by doj").show()
>     checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj"))
>   }
> result:
> +--------------------+
> |                 doj|
> +--------------------+
> |2010-12-29 00:00:...|
> |2007-01-17 00:00:...|
> |2011-11-09 00:00:...|
> |2015-12-01 00:00:...|
> |2013-09-22 00:00:...|
> |2008-05-29 00:00:...|
> |2009-07-07 00:00:...|
> |2012-10-14 00:00:...|
> |2015-05-12 00:00:...|
> |2014-08-15 00:00:...|
> +--------------------+
> |                 doj|
> +--------------------+
> |2007-01-17 00:00:...|
> |2008-05-29 00:00:...|
> |2009-07-07 00:00:...|
> |2010-12-29 00:00:...|
> |2011-11-09 00:00:...|
> |2012-10-14 00:00:...|
> |2013-09-22 00:00:...|
> |2014-08-15 00:00:...|
> |2015-05-12 00:00:...|
> |2015-12-01 00:00:...|
> +--------------------+
> result of test case it passed ,but it should fail
> checkAnswer(sql("select doj from sorttable3"), sql("select doj from sorttable3 order by doj")
> this check is only validating the data not the order of data the real purpose for which sort column is used
> to make sure we are able to verify the functionality of sort columns it test cases must be modified

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)