[
https://issues.apache.org/jira/browse/CARBONDATA-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravindra Pesala updated CARBONDATA-155:
---------------------------------------
Priority: Trivial (was: Major)
> Code refactor to avoid the Type Casting in compareTo method
> -----------------------------------------------------------
>
> Key: CARBONDATA-155
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-155> Project: CarbonData
> Issue Type: Improvement
> Reporter: Mohammad Shahid Khan
> Assignee: Mohammad Shahid Khan
> Priority: Trivial
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> PraveenAdlakha added a note 23 hours ago
> Hi ,
> Would like to suggest a couple of things here remove Comparable from the class definition as Distributable is already implementing it.
> Let use generics so that we donot have to typeCast everywhere in the compare method for that need to do two things:
> 1) Change the class definition of Distributable to :
> public abstract class Distributable> implements Comparable
> 2) Change the compareTo method definition to:
> public int compareTo(TableBlockInfo other)
> Let me know incase you are facing any isssue in doing this I will provide the patch if needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)