[jira] [Updated] (CARBONDATA-1800) Mistyping in DataMapRow compare

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (CARBONDATA-1800) Mistyping in DataMapRow compare

Akash R Nilugal (Jira)

     [ https://issues.apache.org/jira/browse/CARBONDATA-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jiangmanhua updated CARBONDATA-1800:
------------------------------------
    Description:
In BlockletDMComparator  


{code:java}
public int compare(DataMapRow first, DataMapRow second) {
   ...
    byte[][] firstBytes = splitKey(first.getByteArray(0));
    byte[][] secondBytes = splitKey(first.getByteArray(0));
   ...
}
{code}


line 65 and 66 use same input argument, the second line should be assign as "  splitKey(second.getByteArray(0)) "

https://github.com/apache/carbondata/blob/79feac96ae789851c5ad7306a7acaaba25d8e6c9/core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDMComparator.java#L66

  was:
In BlockletDMComparator  

public int compare(DataMapRow first, DataMapRow second) {
   ...
    byte[][] firstBytes = splitKey(first.getByteArray(0));
    byte[][] secondBytes = splitKey(first.getByteArray(0));
   ...
}

line 65 and 66 use same input argument, the second line should be assign as "  splitKey(second.getByteArray(0)) "

https://github.com/apache/carbondata/blob/79feac96ae789851c5ad7306a7acaaba25d8e6c9/core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDMComparator.java#L66


> Mistyping in DataMapRow compare
> -------------------------------
>
>                 Key: CARBONDATA-1800
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-1800
>             Project: CarbonData
>          Issue Type: Bug
>          Components: core
>            Reporter: jiangmanhua
>
> In BlockletDMComparator  
> {code:java}
> public int compare(DataMapRow first, DataMapRow second) {
>    ...
>     byte[][] firstBytes = splitKey(first.getByteArray(0));
>     byte[][] secondBytes = splitKey(first.getByteArray(0));
>    ...
> }
> {code}
> line 65 and 66 use same input argument, the second line should be assign as "  splitKey(second.getByteArray(0)) "
> https://github.com/apache/carbondata/blob/79feac96ae789851c5ad7306a7acaaba25d8e6c9/core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDMComparator.java#L66



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)