[jira] [Updated] (CARBONDATA-2089) Test cases is incorrect because it always run success no matter whether the SQL thrown exception

[Akash R Nilugal (Jira)]

     [ https://issues.apache.org/jira/browse/CARBONDATA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xubo245 updated CARBONDATA-2089:
--------------------------------
    Description:
Test cases is incorrect because it always run success no matter whether the SQL thrown exception,
if the sql run success, then assert(false), and then catch exception and assert(true), so it always true.

Test cases is incorrect,like:


{code:java}
  test("test timeseries create table seven") {
    try {
      sql(
        "create datamap agg0 on table mainTable using 'preaggregate' DMPROPERTIES ('timeseries.eventTime'='dataTime', 'timeseries.hierarchy'='hour=1,day=1,year=1,month=1') as select dataTime, sum(age) from mainTable group by dataTime")
      assert(false)
    } catch {
      case _:Exception =>
        assert(true)
    }
  }
{code}

It will always run success.

SDV have many similar test case, we need to fix it!

  was:
Test cases is incorrect because it always run success no matter whether the SQL thrown exception,
if the sql run success

Test cases is incorrect,like:


{code:java}
  test("test timeseries create table seven") {
    try {
      sql(
        "create datamap agg0 on table mainTable using 'preaggregate' DMPROPERTIES ('timeseries.eventTime'='dataTime', 'timeseries.hierarchy'='hour=1,day=1,year=1,month=1') as select dataTime, sum(age) from mainTable group by dataTime")
      assert(false)
    } catch {
      case _:Exception =>
        assert(true)
    }
  }
{code}

It will always run success.

SDV have many similar test case, we need to fix it!

> Test cases is incorrect because it always run success no matter whether the SQL thrown exception
> ------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-2089
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-2089
>             Project: CarbonData
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1.3.0
>            Reporter: xubo245
>            Assignee: xubo245
>            Priority: Major
>             Fix For: 1.3.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Test cases is incorrect because it always run success no matter whether the SQL thrown exception,
> if the sql run success, then assert(false), and then catch exception and assert(true), so it always true.
> Test cases is incorrect,like:
> {code:java}
>   test("test timeseries create table seven") {
>     try {
>       sql(
>         "create datamap agg0 on table mainTable using 'preaggregate' DMPROPERTIES ('timeseries.eventTime'='dataTime', 'timeseries.hierarchy'='hour=1,day=1,year=1,month=1') as select dataTime, sum(age) from mainTable group by dataTime")
>       assert(false)
>     } catch {
>       case _:Exception =>
>         assert(true)
>     }
>   }
> {code}
> It will always run success.
> SDV have many similar test case, we need to fix it!

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)