[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

Posted by GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Klaus-xjp-opened-a-new-pull-request-3945-CARBONDATA-3991-Fix-the-set-modified-time-tp100742p101159.html


Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##########
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission permission) throws IOException {
     return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission permission)

Review comment:
       It is goog to change Boolean to boolean




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]