[GitHub] [carbondata] akashrn5 commented on a change in pull request #3935: [CARBONDATA-3993] Remove auto data deletion in IUD processs

Posted by GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Pickupolddriver-opened-a-new-pull-request-3935-CARBONDATA-3993-Remove-deletePartias-tp100496p101653.html


akashrn5 commented on a change in pull request #3935:
URL: https://github.com/apache/carbondata/pull/3935#discussion_r503036710



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##########
@@ -267,9 +266,8 @@ object CarbonDataRDDFactory {
             throw new Exception("Exception in compaction " + exception.getMessage)
           }
         } finally {
-          executor.shutdownNow()
           try {
-            compactor.deletePartialLoadsInCompaction()

Review comment:
       @QiangCai how its handled now, without list files? why cant we do list files with the timestamp filter, which is load timestamp/fact timestamp, we can get from load model or somewhere right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]