Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-3979-WIP-Fix-insertion-from-ORC-table-into-carbt-tp101671p101705.html
ajantha-bhat commented on a change in pull request #3979:
URL:
https://github.com/apache/carbondata/pull/3979#discussion_r503099172##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/InsertIntoCarbonTableTestCase.scala
##########
@@ -67,6 +67,21 @@ class InsertIntoCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
}
+ test("insert from orc-select columns with columns having null values and sort scope as global sort") {
+ sql("drop table if exists TORCSource")
+ sql("drop table if exists TCarbon")
+ sql("create table TORCSource(name string,col array<String>,fee int) STORED AS orc")
+ sql("insert into TORCSource values('karan',null,2)")
+ sql("create table TCarbon(name string, col array<String>,fee int) STORED AS carbondata TBLPROPERTIES ('SORT_COLUMNS'='name','TABLE_BLOCKSIZE'='128','TABLE_BLOCKLET_SIZE'='128','SORT_SCOPE'='global_SORT')")
+ sql("insert overwrite table TCarbon select name,col,fee from TORCSource")
+ val result = sql("show segments for table TCarbon").collect()(0).get(1).toString()
+ if(!"Success".equalsIgnoreCase(result)) {
+ assert(false)
+ }
+ sql("drop table if exists TORCSource")
+ sql("drop table if exists TCarbon")
+ }
+
Review comment:
please handle and verify 4 scenarios by comparing with ORC.
a) local sort insert with complex type null value data
b) global sort insert with complex type null value data
c) same point a) with `carbon.enable.bad.record.handling.for.insert `as `true`
d) same point b) with `carbon.enable.bad.record.handling.for.insert` as `true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]