[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3967: [CARBONDATA-4004] [CARBONDATA-4012] Issue with select after update command

Posted by GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-3967-WIP-Read-after-update-command-tp101363p101827.html


VenuReddy2103 commented on a change in pull request #3967:
URL: https://github.com/apache/carbondata/pull/3967#discussion_r503822155



##########
File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
##########
@@ -242,4 +242,8 @@ public void putArray(int rowId, int offset, int length) {
       columnVector.putArray(counter++, offset, length);
     }
   }
+
+  public CarbonColumnVector getColumnVector() {

Review comment:
       `columnVector` is a field defined in parent class. shall we keep this getColumnVector() in its parent class(`AbstractCarbonColumnarVector`) itself. Please add `@Override` annotation to it. It is overriding the method from `CarbonColumnVector` interface




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]