Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-3967-WIP-Read-after-update-command-tp101363p101835.html
VenuReddy2103 commented on a change in pull request #3967:
URL:
https://github.com/apache/carbondata/pull/3967#discussion_r503880242##########
File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/SliceStreamReader.java
##########
@@ -124,6 +124,17 @@ public void putByteArray(int rowId, int count, byte[] value) {
}
}
+ @Override
+ public void putAllByteArray(byte[] data, int offset, int length) {
+ int[] lengths = getLengths();
+ int[] offsets = getOffsets();
+ for (int i = 0; i < lengths.length; i++) {
+ if (offsets[i] != 0) {
Review comment:
Is this check required ? It is LV encoded byte array. Even offsets[0] wouldn't be 0 as it would point to offset of value field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]