Posted by
GitBox on
Oct 14, 2020; 4:51pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-3970-CARBONDATA-4007-Fix-multiple-issues-in-SDKD-tp101429p101986.html
Karan980 commented on a change in pull request #3970:
URL:
https://github.com/apache/carbondata/pull/3970#discussion_r504827820##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonIUD.java
##########
@@ -155,7 +158,15 @@ public void update(String path, Expression filterExpression,
Schema schema = CarbonSchemaReader.readSchema(indexFiles.get(0)).asOriginOrder();
Field[] fields = schema.getFields();
String[] projectionColumns = new String[fields.length + 1];
+ List<Integer> dateIndexes = new ArrayList<>();
+ List<Integer> timeStampIndexes = new ArrayList<>();
for (int i = 0; i < fields.length; i++) {
+ if (fields[i].getDataType() == DataTypes.DATE) {
+ dateIndexes.add(i);
+ }
+ if (fields[i].getDataType() == DataTypes.TIMESTAMP) {
Review comment:
Code removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]