Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-3970-CARBONDATA-4007-Fix-multiple-issues-in-SDKD-tp101429p102265.html
kunal642 commented on a change in pull request #3970:
URL:
https://github.com/apache/carbondata/pull/3970#discussion_r508308091##########
File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java
##########
@@ -1260,8 +1260,8 @@ public int compare(Field o1, Field o2) {
Assert.assertEquals((double) id / 2, row[4]);
Assert.assertEquals(true, (boolean) row[5]);
long day = 24L * 3600 * 1000;
Review comment:
if these valriables are not used then remove it
##########
File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java
##########
@@ -1260,8 +1260,8 @@ public int compare(Field o1, Field o2) {
Assert.assertEquals((double) id / 2, row[4]);
Assert.assertEquals(true, (boolean) row[5]);
long day = 24L * 3600 * 1000;
Review comment:
if these variables are not used then remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]